[deps] Upgrade Django 5.x and channels dependencies from openwisp-utils extras#1001
Merged
Conversation
github-project-automation
Bot
moved this to To do (general)
in OpenWISP Contributor's Board
nemesifier
reviewed
Apr 3, 2025
pandafy
commented
Apr 4, 2025
| path = reverse('geo_api:detail_location', args=[l1.pk]) | ||
| data = {'type': 'outdoor'} | ||
| with self.assertNumQueries(8): | ||
| with self.assertNumQueries(9): |
Member
Author
There was a problem hiding this comment.
The number of queries increased because of these changes openwisp/django-loci#157
- Dropped support for Python < 3.9 - Dropped support for Django < 4.2 Closes #987
Django 5.2 requires Postgresql 14+
pandafy
commented
Apr 4, 2025
| template_qs = Template.objects.filter(type='vpn') | ||
| self.assertEqual(template_qs.count(), 1) | ||
| t = template_qs.first() | ||
| self.assertDictContainsSubset(_original_context, t.get_context()) |
Member
Author
There was a problem hiding this comment.
It is removed in Python 3.12
pandafy
commented
Apr 4, 2025
| self.assertIsNone(c1.device.management_ip) | ||
| self.assertEqual(c2.device.management_ip, '192.168.1.99') | ||
| # other organization is not affected | ||
| self.assertEquals(c3.device.last_ip, '127.0.0.1') |
Member
Author
There was a problem hiding this comment.
It is removed in Python 3.12
pandafy
changed the title
nemesifier
reviewed
Apr 4, 2025
| return context | ||
|
|
||
| with context: | ||
| func(*args, **kwargs) |
nemesifier
approved these changes
Apr 4, 2025
github-project-automation
Bot
moved this from In progress
to Done
in OpenWISP Contributor's Board
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Blockers